Skip to content

[HttpKernel] Document AsController attribute #16748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

[HttpKernel] Document AsController attribute #16748

merged 1 commit into from
Oct 26, 2022

Conversation

SzymonKaminski
Copy link
Contributor

This PR aims to resolve #15144.

@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.4, 6.0, 6.1.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 5.3 milestone Apr 24, 2022
@SzymonKaminski SzymonKaminski changed the base branch from 5.3 to 5.4 April 25, 2022 06:13
@javiereguiluz javiereguiluz modified the milestones: 5.3, 5.4 Oct 26, 2022
@javiereguiluz javiereguiluz merged commit 88d9bf7 into symfony:5.4 Oct 26, 2022
@javiereguiluz
Copy link
Member

Thank you Szymon ... and sorry it took us so long to merge.

@SzymonKaminski SzymonKaminski deleted the as_controller_attribute branch October 4, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HttpKernel Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@SzymonKaminski @carsonbot @javiereguiluz